• Krister Johansen's avatar
    dmaengine: iota: ioat_alloc_chan_resources should not perform sleeping allocations. · 21d25f6a
    Krister Johansen authored
    On a kernel with DEBUG_LOCKS, ioat_free_chan_resources triggers an
    in_interrupt() warning.  With PROVE_LOCKING, it reports detecting a
    SOFTIRQ-safe to SOFTIRQ-unsafe lock ordering in the same code path.
    
    This is because dma_generic_alloc_coherent() checks if the GFP flags
    permit blocking.  It allocates from different subsystems if blocking is
    permitted.  The free path knows how to return the memory to the correct
    allocator.  If GFP_KERNEL is specified then the alloc and free end up
    going through cma_alloc(), which uses mutexes.
    
    Given that ioat_free_chan_resources() can be called in interrupt
    context, ioat_alloc_chan_resources() must specify GFP_NOWAIT so that the
    allocations do not block and instead use an allocator that uses
    spinlocks.
    Signed-off-by: default avatarKrister Johansen <kjlx@templeofstupid.com>
    Acked-by: default avatarDave Jiang <dave.jiang@intel.com>
    Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
    21d25f6a
init.c 38 KB