• Johan Hovold's avatar
    mfd: core: Fix platform-device name collisions · a77c50b4
    Johan Hovold authored
    Since commit 6e3f62f0 ("mfd: core: Fix platform-device id
    generation") we honour PLATFORM_DEVID_AUTO and PLATFORM_DEVID_NONE when
    registering mfd-devices.
    
    Unfortunately, some mfd-drivers rely on the old behaviour of generating
    platform-device ids by adding the cell id also to the special value of
    PLATFORM_DEVID_NONE. The resulting platform ids are not only used to
    generate device-unique names, but are also used instead of the cell id
    to identify cells when probing subdevices.
    
    These drivers should be updated to use PLATFORM_DEVID_AUTO, which would
    also allow more than one device to be registered without resorting to
    hacks (see for example wm831x), but lets fix the regression first by
    partially reverting the above mentioned commit with respect to
    PLATFORM_DEVID_NONE.
    
    Fixes: 6e3f62f0 ("mfd: core: Fix platform-device id generation")
    Cc: stable <stable@vger.kernel.org>	# v3.19
    Reported-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
    Acked-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
    a77c50b4
mfd-core.c 8.12 KB