• Sean Christopherson's avatar
    KVM: x86/mmu: Remove broken WARN that fires on 32-bit KVM w/ nested EPT · f0d43790
    Sean Christopherson authored
    Remove a misguided WARN that attempts to detect the scenario where using
    a special A/D tracking flag will set reserved bits on a non-MMIO spte.
    The WARN triggers false positives when using EPT with 32-bit KVM because
    of the !64-bit clause, which is just flat out wrong.  The whole A/D
    tracking goo is specific to EPT, and one of the big selling points of EPT
    is that EPT is decoupled from the host's native paging mode.
    
    Drop the WARN instead of trying to salvage the check.  Keeping a check
    specific to A/D tracking bits would essentially regurgitate the same code
    that led to KVM needed the tracking bits in the first place.
    
    A better approach would be to add a generic WARN on reserved bits being
    set, which would naturally cover the A/D tracking bits, work for all
    flavors of paging, and be self-documenting to some extent.
    
    Fixes: 8a406c89 ("KVM: x86/mmu: Rename and document A/D scheme for TDP SPTEs")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
    Message-Id: <20210622175739.3610207-2-seanjc@google.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    f0d43790
spte.c 10.9 KB