• Baruch Siach's avatar
    Revert "PCI: armada8k: Add support for gpio controlled reset signal" · f14bcc0a
    Baruch Siach authored
    Revert commit 3d71746c ("PCI: armada8k: Add support for gpio controlled
    reset signal").
    
    That commit breaks boot on Macchiatobin board when a Mellanox NIC is
    present in the PCIe slot.
    
    It turns out that full reset cycle requires first comphy serdes
    initialization. Reset signal toggle without comphy initialization makes
    access to PCI configuration registers stall indefinitely. U-Boot toggles
    the Macchiatobin PCIe reset line already at boot, after initializing the
    comphy serdes.
    
    So while commit 3d71746c ("PCI: armada8k: Add support for gpio controlled
    reset signal") enables PCIe on platforms that U-Boot does not touch the
    reset line (like Clearfog GT-8K), it breaks PCIe (and boot) on the
    Macchiatobin board.
    
    Revert commit 3d71746c ("PCI: armada8k: Add support for gpio controlled
    reset signal") entirely to fix the Macchiatobin regression.
    Reported-by: default avatarSven Auhagen <sven.auhagen@voleatech.de>
    Signed-off-by: default avatarBaruch Siach <baruch@tkos.co.il>
    Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    f14bcc0a
pcie-armada8k.c 7.4 KB