• Christoph Hellwig's avatar
    btrfs: fix dirty_metadata_bytes for redirtied buffers · f18cc978
    Christoph Hellwig authored
    dirty_metadata_bytes is decremented in both places that clear the dirty
    bit in a buffer, but only incremented in btrfs_mark_buffer_dirty, which
    means that a buffer that is redirtied using btrfs_redirty_list_add won't
    be added to dirty_metadata_bytes, but it will be subtracted when written
    out, leading an inconsistency in the counter.
    
    Move the dirty_metadata_bytes from btrfs_mark_buffer_dirty into
    set_extent_buffer_dirty to also account for the redirty case, and remove
    the now unused set_extent_buffer_dirty return value.
    
    Fixes: d3575156 ("btrfs: zoned: redirty released extent buffers")
    CC: stable@vger.kernel.org # 5.15+
    Reviewed-by: default avatarNaohiro Aota <naohiro.aota@wdc.com>
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    f18cc978
disk-io.c 144 KB