• Tejun Heo's avatar
    blk-iocost: revamp donation amount determination · f1de2439
    Tejun Heo authored
    iocost has various safety nets to combat inuse adjustment calculation
    inaccuracies. With Andy's method implemented in transfer_surpluses(), inuse
    adjustment calculations are now accurate and we can make donation amount
    determinations accurate too.
    
    * Stop keeping track of past usage history and using the maximum. Act on the
      immediate usage information.
    
    * Remove donation constraints defined by SURPLUS_* constants. Donate
      whatever isn't used.
    
    * Determine the donation amount so that the iocg will end up with
      MARGIN_TARGET_PCT budget at the end of the coming period assuming the same
      usage as the previous period. TARGET is set at 50% of period, which is the
      previous maximum. This provides smooth convergence for most repetitive IO
      patterns.
    
    * Apply donation logic early at 20% budget. There's no risk in doing so as
      the calculation is based on the delta between the current budget and the
      target budget at the end of the coming period.
    
    * Remove preemptive iocg activation for zero cost IOs. As donation can reach
      near zero now, the mere activation doesn't provide any protection anymore.
      In the unlikely case that this becomes a problem, the right solution is
      assigning appropriate costs for such IOs.
    
    This significantly improves the donation determination logic while also
    simplifying it. Now all donations are immediate, exact and smooth.
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Cc: Andy Newell <newella@fb.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    f1de2439
blk-iocost.c 83.5 KB