• Eric W. Biederman's avatar
    [NETNS]: Simplify the network namespace list locking rules. · f4618d39
    Eric W. Biederman authored
    Denis V. Lunev <den@sw.ru> noticed that the locking rules
    for the network namespace list are over complicated and broken.
    
    In particular the current register_netdev_notifier currently
    does not take any lock making the for_each_net iteration racy
    with network namespace creation and destruction. Oops.
    
    The fact that we need to use for_each_net in rtnl_unlock() when
    the rtnetlink support becomes per network namespace makes designing
    the proper locking tricky.  In addition we need to be able to call
    rtnl_lock() and rtnl_unlock() when we have the net_mutex held.
    
    After thinking about it and looking at the alternatives carefully
    it looks like the simplest and most maintainable solution is
    to remove net_list_mutex altogether, and to use the rtnl_mutex instead.
    Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    f4618d39
net_namespace.h 2.58 KB