• Horatio Zhang's avatar
    drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v10_0_hw_fini · 08c677cb
    Horatio Zhang authored
    The gmc.ecc_irq is enabled by firmware per IFWI setting,
    and the host driver is not privileged to enable/disable
    the interrupt. So, it is meaningless to use the amdgpu_irq_put
    function in gmc_v10_0_hw_fini, which also leads to the call
    trace.
    
    [   82.340264] Call Trace:
    [   82.340265]  <TASK>
    [   82.340269]  gmc_v10_0_hw_fini+0x83/0xa0 [amdgpu]
    [   82.340447]  gmc_v10_0_suspend+0xe/0x20 [amdgpu]
    [   82.340623]  amdgpu_device_ip_suspend_phase2+0x127/0x1c0 [amdgpu]
    [   82.340789]  amdgpu_device_ip_suspend+0x3d/0x80 [amdgpu]
    [   82.340955]  amdgpu_device_pre_asic_reset+0xdd/0x2b0 [amdgpu]
    [   82.341122]  amdgpu_device_gpu_recover.cold+0x4dd/0xbb2 [amdgpu]
    [   82.341359]  amdgpu_debugfs_reset_work+0x4c/0x70 [amdgpu]
    [   82.341529]  process_one_work+0x21d/0x3f0
    [   82.341535]  worker_thread+0x1fa/0x3c0
    [   82.341538]  ? process_one_work+0x3f0/0x3f0
    [   82.341540]  kthread+0xff/0x130
    [   82.341544]  ? kthread_complete_and_exit+0x20/0x20
    [   82.341547]  ret_from_fork+0x22/0x30
    Signed-off-by: default avatarHoratio Zhang <Hongkun.Zhang@amd.com>
    Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
    Reviewed-by: default avatarGuchun Chen <guchun.chen@amd.com>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2522
    Fixes: c8b5a95b ("drm/amdgpu: Fix desktop freezed after gpu-reset")
    Cc: stable@vger.kernel.org
    08c677cb
gmc_v10_0.c 32.6 KB