• Siftar, Gabe's avatar
    tty/serial: atmel_serial: fix RS485 half-duplex problem · 57c36868
    Siftar, Gabe authored
    On our custom board, we are using RS485 in half-duplex mode on an AT91SAM9G45.
    SER_RS485_RX_DURING_TX is not set as we do not want to receive the data we
    transmit (our transceiver will receive transmitted data).
    Although the current driver attempts to disable and enable the receiver at the
    appropriate points, incoming data is still loaded into the receive register
    causing our code to receive the very last byte that was sent once the receiver
    is enabled.
    
    I ran this by Atmel support and they wrote: "The issue comes from the fact
    that you disable the PDC/DMA Reception and not the USART Reception channel. In
    your case, the[n] you will still receive data into the USART_RHR register, and
    maybe you [h]ave the overrun flag set. So please disable the USART reception
    channel."
    
    The following patch should force the driver to enable/disable the receiver via
    RXEN/RXDIS fields of the USART control register. It fixed the issue I was
    having.
    Signed-off-by: default avatarGabe Siftar <gabe.siftar@getingeusa.com>
    [nicolas.ferre@atmel.com: slightly modify commit message]
    Signed-off-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    57c36868
atmel_serial.c 47.2 KB