• Paulo Zanoni's avatar
    drm/i915: get a PC8 reference when enabling the power well · be3d26b0
    Paulo Zanoni authored
    In the current code, at haswell_modeset_global_resources, first we
    decide if we want to enable/disable the power well, then we decide if
    we want to enable/disable PC8. On the case where we're enabling PC8
    this works fine, but on the case where we disable PC8 due to a non-eDP
    monitor being enabled, we first enable the power well and then disable
    PC8. Although wrong, this doesn't seem to be causing any problems now,
    and we don't even see anything in dmesg. But the patches for runtime
    D3 turn this problem into a real bug, so we need to fix it.
    
    This fixes the "modeset-non-lpsp" subtest from the "pm_pc8" test from
    intel-gpu-tools.
    
    v2: - Rebase (i915_disable_power_well).
    v3: - More reabase.
    v4: - Rebase on top of -fixes instead of -nightly.
    
    This is commit d62292c8 in -next, but
    we need it in -fixes to address Dave's report.
    Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
    Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@gmail.com>
    Reported-by: default avatarDave Jones <davej@redhat.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    be3d26b0
intel_pm.c 172 KB