• Eric Dumazet's avatar
    ipv6: remove hard coded limitation on ipv6_pinfo · f5f80e32
    Eric Dumazet authored
    IPv6 inet sockets are supposed to have a "struct ipv6_pinfo"
    field at the end of their definition, so that inet6_sk_generic()
    can derive from socket size the offset of the "struct ipv6_pinfo".
    
    This is very fragile, and prevents adding bigger alignment
    in sockets, because inet6_sk_generic() does not work
    if the compiler adds padding after the ipv6_pinfo component.
    
    We are currently working on a patch series to reorganize
    TCP structures for better data locality and found issues
    similar to the one fixed in commit f5d54767
    ("tcp: fix tcp_inet6_sk() for 32bit kernels")
    
    Alternative would be to force an alignment on "struct ipv6_pinfo",
    greater or equal to __alignof__(any ipv6 sock) to ensure there is
    no padding. This does not look great.
    
    v2: fix typo in mptcp_proto_v6_init() (Paolo)
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Cc: Chao Wu <wwchao@google.com>
    Cc: Wei Wang <weiwan@google.com>
    Cc: Coco Li <lixiaoyan@google.com>
    Cc: YiFei Zhu <zhuyifei@google.com>
    Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    f5f80e32
ipv6.h 8.08 KB