• Marc Kleine-Budde's avatar
    i2c-imx: do not allow interruptions when waiting for I2C to complete · e39428d5
    Marc Kleine-Budde authored
    The i2c_imx_trx_complete() function is using
    wait_event_interruptible_timeout() to wait for the I2C controller to
    signal that it has completed an I2C bus operation. If the process that
    causes the I2C operation receives a signal, the wait will be
    interrupted, returning an error. It is better to let the I2C operation
    finished before handling the signal (i.e. returning into userspace).
    
    It is safe to use wait_event_timeout() instead, because the timeout
    will allow the process to exit if the I2C bus hangs. It's also better
    to allow the I2C operation to finish, because unacknowledged I2C
    operations can cause the I2C bus to hang.
    Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
    Reviewed-by: default avatarWolfram Sang <w.sang@pengutronix.de>
    Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
    e39428d5
i2c-imx.c 17.6 KB