• Greg Thelen's avatar
    selftests: more general make nesting support · f69237e1
    Greg Thelen authored
    selftests can be built from the toplevel kernel makefile (e.g. make
    kselftest-all) or directly (make -C tools/testing/selftests all).
    
    The toplevel kernel makefile explicitly disables implicit rules with
    "MAKEFLAGS += -rR", which is passed to tools/testing/selftests.  Some
    selftest makefiles require implicit make rules, which is why
    commit 67d8712d ("selftests: Fix build failures when invoked from
    kselftest target") reenables implicit rules by clearing MAKEFLAGS if
    MAKELEVEL=1.
    
    So far so good.  However, if the toplevel makefile is called from an
    outer makefile then MAKELEVEL will be elevated, which breaks the
    MAKELEVEL equality test.
    Example wrapped makefile error:
      $ cat ~/Makefile
      all:
      	$(MAKE) defconfig
      	$(MAKE) kselftest-all
      $ make -sf ~/Makefile
        futex_wait_timeout.c /src/tools/testing/selftests/kselftest_harness.h   /src/tools/testing/selftests/kselftest.h ../include/futextest.h ../include/atomic.h ../include/logging.h -lpthread -lrt -o /src/tools/testing/selftests/futex/functional/futex_wait_timeout
      make[4]: futex_wait_timeout.c: Command not found
    
    Rather than checking $(MAKELEVEL), check for $(LINK.c), which is a more
    direct side effect of "make -R".  This enables arbitrary makefile
    nesting.
    Signed-off-by: default avatarGreg Thelen <gthelen@google.com>
    Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
    f69237e1
Makefile 7.99 KB