• Alexey Kardashevskiy's avatar
    powerpc/powernv: Fix opal tracepoints with JUMP_LABEL=n · 2a9c4f40
    Alexey Kardashevskiy authored
    The recent commit to allow calling OPAL calls in real mode, commit
    ab9bad0e ("powerpc/powernv: Remove separate entry for OPAL real mode
    calls"), introduced a bug when CONFIG_JUMP_LABEL=n.
    
    The commit moved the "mfmsr r12" prior to the call to OPAL_BRANCH, but
    we missed that OPAL_BRANCH clobbers r12 when jump labels are disabled.
    This leads to us using the tracepoint refcount as the MSR value,
    typically zero, and saving that into PACASAVEDMSR. When we return from
    OPAL we use that value as the MSR value for rfid, meaning we switch to
    32-bit BE real mode - hilarity ensues.
    
    Fix it by using r11 in OPAL_BRANCH, which is not live at the time the
    macro is used in OPAL_CALL.
    
    Fixes: ab9bad0e ("powerpc/powernv: Remove separate entry for OPAL real mode calls")
    Suggested-by: default avatarPaul Mackerras <paulus@samba.org>
    Signed-off-by: default avatarAlexey Kardashevskiy <aik@ozlabs.ru>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    2a9c4f40
opal-wrappers.S 10.1 KB