• Kevin Cernekee's avatar
    netfilter: ctnetlink: Fix regression in CTA_HELP processing · f95d7a46
    Kevin Cernekee authored
    Prior to Linux 4.4, it was usually harmless to send a CTA_HELP attribute
    containing the name of the current helper.  That is no longer the case:
    as of Linux 4.4, if ctnetlink_change_helper() returns an error from
    the ct->master check, processing of the request will fail, skipping the
    NFQA_EXP attribute (if present).
    
    This patch changes the behavior to improve compatibility with user
    programs that expect the kernel interface to work the way it did prior
    to Linux 4.4.  If a user program specifies CTA_HELP but the argument
    matches the current conntrack helper name, ignore it instead of generating
    an error.
    Signed-off-by: default avatarKevin Cernekee <cernekee@chromium.org>
    Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
    f95d7a46
nf_conntrack_netlink.c 83.4 KB