• Thomas Richter's avatar
    s390/qeth: test RX/TX checksum offload reply · f9d8e6dc
    Thomas Richter authored
    Turning on receive and/or transmit checksum offload support
    on the OSA card requires 2 commands:
    1. start command which replies with available features
    2. enable command to turn on selected features.
    
    The current version does not check the reply of the start
    command and simply uses the returned value to enable
    offload features. When the start command returns zero, this
    leads to a situation where no checksum offload
    is turned on by the hardware. Even worse no error
    indication is returned. The Linux kernel assumes
    the OSA card performs RX/TX checksum offload, but the hardware
    does not perform any checksum verification at all.
    
    This patch checks the return of the start and enable
    command responses from the hardware and turns off
    checksum offloading if the commands fails or does not
    respond with the correct bit setting.
    Signed-off-by: default avatarThomas Richter <tmricht@linux.vnet.ibm.com>
    Reviewed-by: default avatarJulian Wiedmann <jwi@linux.vnet.ibm.com>
    Reviewed-by: default avatarUrsula Braun <ubraun@linux.vnet.ibm.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    f9d8e6dc
qeth_core_mpc.h 23.2 KB