• Ian Rogers's avatar
    perf stat: Fix memory leak in check_per_pkg() · f9e891ea
    Ian Rogers authored
    If the key is already present then free the key used for lookup.
    
    Found with:
    $ perf stat -M IO_Read_BW /bin/true
    
    ==1749112==ERROR: LeakSanitizer: detected memory leaks
    
    Direct leak of 32 byte(s) in 4 object(s) allocated from:
        #0 0x7f6f6fa7d7cf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
        #1 0x55acecd9d7a6 in check_per_pkg util/stat.c:343
        #2 0x55acecd9d9c5 in process_counter_values util/stat.c:365
        #3 0x55acecd9e0ab in process_counter_maps util/stat.c:421
        #4 0x55acecd9e292 in perf_stat_process_counter util/stat.c:443
        #5 0x55aceca8553e in read_counters ./tools/perf/builtin-stat.c:470
        #6 0x55aceca88fe3 in __run_perf_stat ./tools/perf/builtin-stat.c:1023
        #7 0x55aceca89146 in run_perf_stat ./tools/perf/builtin-stat.c:1048
        #8 0x55aceca90858 in cmd_stat ./tools/perf/builtin-stat.c:2555
        #9 0x55acecc05fa5 in run_builtin ./tools/perf/perf.c:313
        #10 0x55acecc064fe in handle_internal_command ./tools/perf/perf.c:365
        #11 0x55acecc068bb in run_argv ./tools/perf/perf.c:409
        #12 0x55acecc070aa in main ./tools/perf/perf.c:539
    Reviewed-by: default avatarJames Clark <james.clark@arm.com>
    Signed-off-by: default avatarIan Rogers <irogers@google.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: John Garry <john.garry@huawei.com>
    Cc: Kajol Jain <kjain@linux.ibm.com>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Leo Yan <leo.yan@linaro.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
    Cc: Mike Leach <mike.leach@linaro.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Paul Clarke <pc@us.ibm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Riccardo Mancini <rickyman7@gmail.com>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
    Cc: Vineet Singh <vineet.singh@intel.com>
    Cc: coresight@lists.linaro.org
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: zhengjun.xing@intel.com
    Link: https://lore.kernel.org/r/20220105061351.120843-24-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    f9e891ea
stat.c 13.7 KB