• Arnd Bergmann's avatar
    media: i2c: add KConfig dependencies · fa31c117
    Arnd Bergmann authored
    The new ov5670 driver fails to build when VIDEO_V4L2_SUBDEV_API
    or MEDIA_CONTROLLER are disabled:
    
    drivers/media/i2c/ov5670.c: In function 'ov5670_open':
    drivers/media/i2c/ov5670.c:1917:5: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? [-Werror=implicit-function-declaration]
         v4l2_subdev_get_try_format(sd, fh->pad, 0);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
         v4l2_subdev_notify_event
    drivers/media/i2c/ov5670.c:1917:38: error: 'struct v4l2_subdev_fh' has no member named 'pad'
         v4l2_subdev_get_try_format(sd, fh->pad, 0);
                                          ^~
    drivers/media/i2c/ov5670.c: In function 'ov5670_do_get_pad_format':
    drivers/media/i2c/ov5670.c:2198:17: error: invalid type argument of unary '*' (have 'int')
       fmt->format = *v4l2_subdev_get_try_format(&ov5670->sd, cfg,
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              fmt->pad);
              ~~~~~~~~~
    drivers/media/i2c/ov5670.c: At top level:
    drivers/media/i2c/ov5670.c:2444:19: error: 'v4l2_subdev_link_validate' undeclared here (not in a function); did you mean 'v4l2_subdev_init'?
      .link_validate = v4l2_subdev_link_validate,
                       ^~~~~~~~~~~~~~~~~~~~~~~~~
                       v4l2_subdev_init
    drivers/media/i2c/ov5670.c: In function 'ov5670_probe':
    drivers/media/i2c/ov5670.c:2492:12: error: 'struct v4l2_subdev' has no member named 'entity'
    
    This adds both to the Kconfig entry.
    
    Fixes: 5de35c9b ("media: i2c: Add Omnivision OV5670 5M sensor support")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    fa31c117
Kconfig 25.6 KB