• Steven Rostedt (Google)'s avatar
    ring-buffer: Allow splice to read previous partially read pages · fa8f4a89
    Steven Rostedt (Google) authored
    If a page is partially read, and then the splice system call is run
    against the ring buffer, it will always fail to read, no matter how much
    is in the ring buffer. That's because the code path for a partial read of
    the page does will fail if the "full" flag is set.
    
    The splice system call wants full pages, so if the read of the ring buffer
    is not yet full, it should return zero, and the splice will block. But if
    a previous read was done, where the beginning has been consumed, it should
    still be given to the splice caller if the rest of the page has been
    written to.
    
    This caused the splice command to never consume data in this scenario, and
    let the ring buffer just fill up and lose events.
    
    Link: https://lkml.kernel.org/r/20220927144317.46be6b80@gandalf.local.home
    
    Cc: stable@vger.kernel.org
    Fixes: 8789a9e7 ("ring-buffer: read page interface")
    Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
    fa8f4a89
ring_buffer.c 161 KB