• Michael Krufky's avatar
    V4L/DVB: tda18271: fix error detection during initialization of first instance · fab9bfbe
    Michael Krufky authored
    Fix error detection of failures during initialization of first instance:
    Dont pass a function into the tda_fail macro. Instead, save the function
    return value and pass that into the tda_fail macro.
    
    This prevents the function from being called twice in cases of failure,
    for example:
    
    [19026.074070] tuner 4-0060: chip found @ 0xc0 (device #0)
    [19026.087755] tda18271 4-0060: creating new instance
    [19026.089965] Unknown device detected @ 4-0060, device not supported.
    [19026.092233] Unknown device detected @ 4-0060, device not supported.
    [19026.092241] tda18271_attach: [4-0060|M] error -22 on line 1275
    [19026.092327] tda18271 4-0060: destroying instance
    Signed-off-by: default avatarMichael Krufky <mkrufky@kernellabs.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    fab9bfbe
tda18271-fe.c 31.7 KB