• Gabriel Paubert's avatar
    mv643xx_eth: Fix use of uninitialized port_num field · fadac406
    Gabriel Paubert authored
    In this driver, the default ethernet address is first set by by calling
    eth_port_uc_addr_get() which reads the relevant registers of the
    corresponding port as initially set by firmware. However that function
    used the port_num field accessed through the private area of net_dev
    before it was set.
    
    The result was that one board I have ended up with the unicast address
    set to 00:00:00:00:00:00 (only port 1 is connected on this board). The
    problem appeared after commit 84dd619e.
    
    This patch fixes the bug by setting mp->port_num prior to calling
    eth_port_uc_get_addr().
    Signed-off-by: default avatarGabriel Paubert <paubert@iram.es>
    Signed-off-by: default avatarDale Farnsworth <dale@farnsworth.org>
    Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
    fadac406
mv643xx_eth.c 80.8 KB