• Stephen Boyd's avatar
    clk: Allow parents to be specified without string names · fc0c209c
    Stephen Boyd authored
    The common clk framework is lacking in ability to describe the clk
    topology without specifying strings for every possible parent-child
    link. There are a few drawbacks to the current approach:
    
     1) String comparisons are used for everything, including describing
     topologies that are 'local' to a single clock controller.
    
     2) clk providers (e.g. i2c clk drivers) need to create globally unique
     clk names to avoid collisions in the clk namespace, leading to awkward
     name generation code in various clk drivers.
    
     3) DT bindings may not fully describe the clk topology and linkages
     between clk controllers because drivers can easily rely on globally unique
     strings to describe connections between clks.
    
    This leads to confusing DT bindings, complicated clk name generation
    code, and inefficient string comparisons during clk registration just so
    that the clk framework can detect the topology of the clk tree.
    Furthermore, some drivers call clk_get() and then __clk_get_name() to
    extract the globally unique clk name just so they can specify the parent
    of the clk they're registering. We have of_clk_parent_fill() but that
    mostly only works for single clks registered from a DT node, which isn't
    the norm. Let's simplify this all by introducing two new ways of
    specifying clk parents.
    
    The first method is an array of pointers to clk_hw structures
    corresponding to the parents at that index. This works for clks that are
    registered when we have access to all the clk_hw pointers for the
    parents.
    
    The second method is a mix of clk_hw pointers and strings of local and
    global parent clk names. If the .fw_name member of the map is set we'll
    look for that clk by performing a DT based lookup of the device the clk
    is registered with and the .name specified in the map. If that fails,
    we'll fallback to the .name member and perform a global clk name lookup
    like we've always done before.
    
    Using either one of these new methods is entirely optional. Existing
    drivers will continue to work, and they can migrate to this new approach
    as they see fit. Eventually, we'll want to get rid of the 'parent_names'
    array in struct clk_init_data and use one of these new methods instead.
    
    Cc: Miquel Raynal <miquel.raynal@bootlin.com>
    Cc: Jerome Brunet <jbrunet@baylibre.com>
    Cc: Russell King <linux@armlinux.org.uk>
    Cc: Michael Turquette <mturquette@baylibre.com>
    Cc: Jeffrey Hugo <jhugo@codeaurora.org>
    Cc: Chen-Yu Tsai <wens@csie.org>
    Cc: Rob Herring <robh@kernel.org>
    Tested-by: default avatarJeffrey Hugo <jhugo@codeaurora.org>
    Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
    fc0c209c
clk.c 113 KB