• Paul E. McKenney's avatar
    rcu: Clean up code based on review feedback from Josh Triplett · fc2219d4
    Paul E. McKenney authored
    These issues identified during an old-fashioned face-to-face code
    review extended over many hours.
    
    o	Bury various forms of the "rsp->completed == rsp->gpnum"
    	comparison into an rcu_gp_in_progress() function, which has
    	the beneficial side-effect of forcing consistent use of
    	ACCESS_ONCE().
    
    o	Replace hand-coded arithmetic with DIV_ROUND_UP().
    
    o	Bury several "!list_empty(&rnp->blocked_tasks[rnp->gpnum & 0x01])"
    	instances into an rcu_preempted_readers() function, as this
    	expression indicates that there are no readers blocked
    	within RCU read-side critical sections blocking the current
    	grace period.  (Though there might well be similar readers
    	blocking the next grace period.)
    
    o	Remove a dangling rcu_restart_cpu() declaration that has
    	been dangling for almost 20 minor releases of the kernel.
    Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
    Acked-by: default avatarPeter Zijlstra <peterz@infradead.org>
    Cc: laijs@cn.fujitsu.com
    Cc: dipankar@in.ibm.com
    Cc: akpm@linux-foundation.org
    Cc: mathieu.desnoyers@polymtl.ca
    Cc: josh@joshtriplett.org
    Cc: dvhltc@us.ibm.com
    Cc: niv@us.ibm.com
    Cc: rostedt@goodmis.org
    Cc: Valdis.Kletnieks@vt.edu
    Cc: dhowells@redhat.com
    LKML-Reference: <12537246442687-git-send-email->
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    fc2219d4
rcutree.h 9.78 KB