• Jiri Slaby's avatar
    TTY: isdn/gigaset, do not set tty->driver_data to NULL · fc258f89
    Jiri Slaby authored
    Close the window in open where driver_data is reset to NULL on each
    open. It could cause other processes to get invalid retval from the
    tty->ops operations because of the checks all over the code.
    
    With this change we may do other cleanups. Now, the only valid check
    for tty->driver_data != NULL is in close. This can happen only if open
    fails at gigaset_get_cs_by_tty or try_module_get. The rest of checks
    in various tty->ops->* are invalid as driver_data cannot be NULL
    there. The same holds for cs->open_count. So remove them.
    Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
    Cc: Hansjoerg Lipp <hjlipp@web.de>
    Cc: Tilman Schmidt <tilman@imap.cc>
    Cc: gigaset307x-common@lists.sourceforge.net
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    fc258f89
interface.c 14.8 KB