• Miquel Raynal's avatar
    nvmem: core: Rework layouts to become regular devices · fc29fd82
    Miquel Raynal authored
    Current layout support was initially written without modules support in
    mind. When the requirement for module support rose, the existing base
    was improved to adopt modularization support, but kind of a design flaw
    was introduced. With the existing implementation, when a storage device
    registers into NVMEM, the core tries to hook a layout (if any) and
    populates its cells immediately. This means, if the hardware description
    expects a layout to be hooked up, but no driver was provided for that,
    the storage medium will fail to probe and try later from
    scratch. Even if we consider that the hardware description shall be
    correct, we could still probe the storage device (especially if it
    contains the rootfs).
    
    One way to overcome this situation is to consider the layouts as
    devices, and leverage the native notifier mechanism. When a new NVMEM
    device is registered, we can populate its nvmem-layout child, if any,
    and wait for the matching to be done in order to get the cells (the
    waiting can be easily done with the NVMEM notifiers). If the layout
    driver is compiled as a module, it should automatically be loaded. This
    way, there is no strong order to enforce, any NVMEM device creation
    or NVMEM layout driver insertion will be observed as a new event which
    may lead to the creation of additional cells, without disturbing the
    probes with costly (and sometimes endless) deferrals.
    
    In order to achieve that goal we create a new bus for the nvmem-layouts
    with minimal logic to match nvmem-layout devices with nvmem-layout
    drivers. All this infrastructure code is created in the layouts.c file.
    Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
    Tested-by: default avatarRafał Miłecki <rafal@milecki.pl>
    Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
    Link: https://lore.kernel.org/r/20231215111536.316972-7-srinivas.kandagatla@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    fc29fd82
onie-tlv.c 5.69 KB