• Sven Eckelmann's avatar
    batman-adv: Don't skb_split skbuffs with frag_list · a063f2fb
    Sven Eckelmann authored
    The receiving interface might have used GRO to receive more fragments than
    MAX_SKB_FRAGS fragments. In this case, these will not be stored in
    skb_shinfo(skb)->frags but merged into the frag list.
    
    batman-adv relies on the function skb_split to split packets up into
    multiple smaller packets which are not larger than the MTU on the outgoing
    interface. But this function cannot handle frag_list entries and is only
    operating on skb_shinfo(skb)->frags. If it is still trying to split such an
    skb and xmit'ing it on an interface without support for NETIF_F_FRAGLIST,
    then validate_xmit_skb() will try to linearize it. But this fails due to
    inconsistent information. And __pskb_pull_tail will trigger a BUG_ON after
    skb_copy_bits() returns an error.
    
    In case of entries in frag_list, just linearize the skb before operating on
    it with skb_split().
    Reported-by: default avatarFelix Kaechele <felix@kaechele.ca>
    Fixes: c6c8fea2 ("net: Add batman-adv meshing protocol")
    Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
    Tested-by: default avatarFelix Kaechele <felix@kaechele.ca>
    Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
    a063f2fb
fragmentation.c 16.2 KB