• John Ogness's avatar
    fs/proc: Report eip/esp in /prod/PID/stat for coredumping · fd7d5627
    John Ogness authored
    Commit 0a1eb2d4 ("fs/proc: Stop reporting eip and esp in
    /proc/PID/stat") stopped reporting eip/esp because it is
    racy and dangerous for executing tasks. The comment adds:
    
        As far as I know, there are no use programs that make any
        material use of these fields, so just get rid of them.
    
    However, existing userspace core-dump-handler applications (for
    example, minicoredumper) are using these fields since they
    provide an excellent cross-platform interface to these valuable
    pointers. So that commit introduced a user space visible
    regression.
    
    Partially revert the change and make the readout possible for
    tasks with the proper permissions and only if the target task
    has the PF_DUMPCORE flag set.
    
    Fixes: 0a1eb2d4 ("fs/proc: Stop reporting eip and esp in> /proc/PID/stat")
    Reported-by: default avatarMarco Felsch <marco.felsch@preh.de>
    Signed-off-by: default avatarJohn Ogness <john.ogness@linutronix.de>
    Reviewed-by: default avatarAndy Lutomirski <luto@kernel.org>
    Cc: Tycho Andersen <tycho.andersen@canonical.com>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: stable@vger.kernel.org
    Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Linux API <linux-api@vger.kernel.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Link: http://lkml.kernel.org/r/87poatfwg6.fsf@linutronix.deSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    fd7d5627
array.c 20.3 KB