• Alexandre Belloni's avatar
    usb: gadget: udc: atmel: fix endpoint name · fe4af125
    Alexandre Belloni authored
    commit bbe097f0 upstream.
    
    Since commit c32b5bcf ("ARM: dts: at91: Fix USB endpoint nodes"),
    atmel_usba_udc fails with:
    
    ------------[ cut here ]------------
    WARNING: CPU: 0 PID: 0 at include/linux/usb/gadget.h:405
    ecm_do_notify+0x188/0x1a0
    Modules linked in:
    CPU: 0 PID: 0 Comm: swapper Not tainted 4.7.0+ #15
    Hardware name: Atmel SAMA5
    [<c010ccfc>] (unwind_backtrace) from [<c010a7ec>] (show_stack+0x10/0x14)
    [<c010a7ec>] (show_stack) from [<c0115c10>] (__warn+0xe4/0xfc)
    [<c0115c10>] (__warn) from [<c0115cd8>] (warn_slowpath_null+0x20/0x28)
    [<c0115cd8>] (warn_slowpath_null) from [<c04377ac>] (ecm_do_notify+0x188/0x1a0)
    [<c04377ac>] (ecm_do_notify) from [<c04379a4>] (ecm_set_alt+0x74/0x1ac)
    [<c04379a4>] (ecm_set_alt) from [<c042f74c>] (composite_setup+0xfc0/0x19f8)
    [<c042f74c>] (composite_setup) from [<c04356e8>] (usba_udc_irq+0x8f4/0xd9c)
    [<c04356e8>] (usba_udc_irq) from [<c013ec9c>] (handle_irq_event_percpu+0x9c/0x158)
    [<c013ec9c>] (handle_irq_event_percpu) from [<c013ed80>] (handle_irq_event+0x28/0x3c)
    [<c013ed80>] (handle_irq_event) from [<c01416d4>] (handle_fasteoi_irq+0xa0/0x168)
    [<c01416d4>] (handle_fasteoi_irq) from [<c013e3f8>] (generic_handle_irq+0x24/0x34)
    [<c013e3f8>] (generic_handle_irq) from [<c013e640>] (__handle_domain_irq+0x54/0xa8)
    [<c013e640>] (__handle_domain_irq) from [<c010b214>] (__irq_svc+0x54/0x70)
    [<c010b214>] (__irq_svc) from [<c0107eb0>] (arch_cpu_idle+0x38/0x3c)
    [<c0107eb0>] (arch_cpu_idle) from [<c0137300>] (cpu_startup_entry+0x9c/0xdc)
    [<c0137300>] (cpu_startup_entry) from [<c0900c40>] (start_kernel+0x354/0x360)
    [<c0900c40>] (start_kernel) from [<20008078>] (0x20008078)
    ---[ end trace e7cf9dcebf4815a6 ]---
    
    Fixes: c32b5bcf ("ARM: dts: at91: Fix USB endpoint nodes")
    Reported-by: default avatarRichard Genoud <richard.genoud@gmail.com>
    Acked-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
    Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
    Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    fe4af125
atmel_usba_udc.c 53.9 KB