• Jean Delvare's avatar
    soc: mediatek: Let PMIC Wrapper and SCPSYS depend on OF · 2778caed
    Jean Delvare authored
    With the following configuration options:
    CONFIG_OF is not set
    CONFIG_MTK_PMIC_WRAP=y
    CONFIG_MTK_SCPSYS=y
    we get the following build warnings:
    
      CC      drivers/soc/mediatek/mtk-pmic-wrap.o
    drivers/soc/mediatek/mtk-pmic-wrap.c:2138:34: warning: ‘of_pwrap_match_tbl’ defined but not used [-Wunused-const-variable=]
    drivers/soc/mediatek/mtk-pmic-wrap.c:1953:34: warning: ‘of_slave_match_tbl’ defined but not used [-Wunused-const-variable=]
      CC      drivers/soc/mediatek/mtk-scpsys.o
    drivers/soc/mediatek/mtk-scpsys.c:1084:34: warning: ‘of_scpsys_match_tbl’ defined but not used [-Wunused-const-variable=]
    
    Looking at the code, both drivers can only bind to OF-defined device
    nodes, so these drivers are useless without OF and should therefore
    depend on it.
    
    Also drop of_match_ptr() from both drivers. We already know what it
    will resolve to, so we might as well save cpp some work.
    
    Developers or QA teams who wish to test-build the code can still do
    so by enabling CONFIG_OF, which is available on all architectures and
    has no dependencies.
    Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Link: https://lore.kernel.org/all/202207240252.ZY5hSCNB-lkp@intel.com/
    Cc: Matthias Brugger <matthias.bgg@gmail.com>
    Cc: Chenglin Xu <chenglin.xu@mediatek.com>
    Link: https://lore.kernel.org/r/20220730144833.0a0d9825@endymion.delvareSigned-off-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
    2778caed
mtk-pmic-wrap.c 60.6 KB