Commit 00135fc5 authored by Ivan Safonov's avatar Ivan Safonov Committed by Greg Kroah-Hartman

staging:r8188eu: Remove rx_handler_data unnecessary read

Rx handler (assigned with netdev_rx_handler_register,
called from __netif_receive_skb()) uses value of dev->rx_handler_data.
The driver has no rx handler and does not need it, so remove rx_handler_data read.
Signed-off-by: default avatarIvan Safonov <insafonov@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6c4187b7
...@@ -9,11 +9,6 @@ TODO: ...@@ -9,11 +9,6 @@ TODO:
- merge Realtek's bugfixes and new features into the driver - merge Realtek's bugfixes and new features into the driver
- switch to use LIB80211 - switch to use LIB80211
- switch to use MAC80211 - switch to use MAC80211
- figure out what to do with this code in rtw_recv_indicatepkt():
rcu_read_lock();
rcu_dereference(padapter->pnetdev->rx_handler_data);
rcu_read_unlock();
Perhaps delete it, perhaps assign to some local variable.
Please send any patches to Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Please send any patches to Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
and Larry Finger <Larry.Finger@lwfinger.net>. and Larry Finger <Larry.Finger@lwfinger.net>.
...@@ -121,10 +121,6 @@ int rtw_recv_indicatepkt(struct adapter *padapter, ...@@ -121,10 +121,6 @@ int rtw_recv_indicatepkt(struct adapter *padapter,
} }
} }
rcu_read_lock();
rcu_dereference(padapter->pnetdev->rx_handler_data);
rcu_read_unlock();
skb->ip_summed = CHECKSUM_NONE; skb->ip_summed = CHECKSUM_NONE;
skb->dev = padapter->pnetdev; skb->dev = padapter->pnetdev;
skb->protocol = eth_type_trans(skb, padapter->pnetdev); skb->protocol = eth_type_trans(skb, padapter->pnetdev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment