Commit 00203737 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Shawn Guo

arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up

The PMIC's interrupt is level low and should be pulled up.  The PMIC's
device node had pinctrl-0 property but it lacked pinctrl-names which
is required to apply the pin configuration.  The actual problem in DTS
was pointed out by Felix Radensky from Variscite.
Reported-by: default avatarFelix Radensky <felix.r@variscite.com>
Fixes: 5f67317b ("arm64: dts: imx8mm: correct interrupt flags")
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: default avatarRobin Gong <yibin.gong@nxp.com>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent ccee91b5
...@@ -135,13 +135,10 @@ &i2c1 { ...@@ -135,13 +135,10 @@ &i2c1 {
pmic@4b { pmic@4b {
compatible = "rohm,bd71847"; compatible = "rohm,bd71847";
reg = <0x4b>; reg = <0x4b>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_pmic>; pinctrl-0 = <&pinctrl_pmic>;
interrupt-parent = <&gpio2>; interrupt-parent = <&gpio2>;
/* interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
* The interrupt is not correct. It should be level low,
* however with internal pull up this causes IRQ storm.
*/
interrupts = <8 IRQ_TYPE_EDGE_RISING>;
rohm,reset-snvs-powered; rohm,reset-snvs-powered;
#clock-cells = <0>; #clock-cells = <0>;
...@@ -398,7 +395,7 @@ MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3 ...@@ -398,7 +395,7 @@ MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3
pinctrl_pmic: pmicirqgrp { pinctrl_pmic: pmicirqgrp {
fsl,pins = < fsl,pins = <
MX8MM_IOMUXC_SD1_DATA6_GPIO2_IO8 0x41 MX8MM_IOMUXC_SD1_DATA6_GPIO2_IO8 0x141
>; >;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment