Commit 0169daec authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Mauro Carvalho Chehab

media: rcar_fdp1: constify vb2_ops structure

Check for vb2_ops structures that are only stored in the ops field of a
vb2_queue structure. That field is declared const, so vb2_ops structures
that have this property can be declared as const also.

This issue was detected using Coccinelle and the following semantic patch:

@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i@p = { ... };

@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 7e645125
...@@ -2032,7 +2032,7 @@ static void fdp1_stop_streaming(struct vb2_queue *q) ...@@ -2032,7 +2032,7 @@ static void fdp1_stop_streaming(struct vb2_queue *q)
} }
} }
static struct vb2_ops fdp1_qops = { static const struct vb2_ops fdp1_qops = {
.queue_setup = fdp1_queue_setup, .queue_setup = fdp1_queue_setup,
.buf_prepare = fdp1_buf_prepare, .buf_prepare = fdp1_buf_prepare,
.buf_queue = fdp1_buf_queue, .buf_queue = fdp1_buf_queue,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment