Commit 0268263f authored by Daniel Wagner's avatar Daniel Wagner Committed by Wolfram Sang

i2c: meson: Use complete() instead of complete_all()

There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().

The usage pattern of the completion is:

meson_i2c_xfer_msg()
  reinit_completion()
  ...
  /* Start the transfer */
  ...
  wait_for_completion_timeout()
Signed-off-by: default avatarDaniel Wagner <daniel.wagner@bmw-carit.de>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent fea03a6a
...@@ -211,7 +211,7 @@ static void meson_i2c_stop(struct meson_i2c *i2c) ...@@ -211,7 +211,7 @@ static void meson_i2c_stop(struct meson_i2c *i2c)
meson_i2c_add_token(i2c, TOKEN_STOP); meson_i2c_add_token(i2c, TOKEN_STOP);
} else { } else {
i2c->state = STATE_IDLE; i2c->state = STATE_IDLE;
complete_all(&i2c->done); complete(&i2c->done);
} }
} }
...@@ -238,7 +238,7 @@ static irqreturn_t meson_i2c_irq(int irqno, void *dev_id) ...@@ -238,7 +238,7 @@ static irqreturn_t meson_i2c_irq(int irqno, void *dev_id)
dev_dbg(i2c->dev, "error bit set\n"); dev_dbg(i2c->dev, "error bit set\n");
i2c->error = -ENXIO; i2c->error = -ENXIO;
i2c->state = STATE_IDLE; i2c->state = STATE_IDLE;
complete_all(&i2c->done); complete(&i2c->done);
goto out; goto out;
} }
...@@ -269,7 +269,7 @@ static irqreturn_t meson_i2c_irq(int irqno, void *dev_id) ...@@ -269,7 +269,7 @@ static irqreturn_t meson_i2c_irq(int irqno, void *dev_id)
break; break;
case STATE_STOP: case STATE_STOP:
i2c->state = STATE_IDLE; i2c->state = STATE_IDLE;
complete_all(&i2c->done); complete(&i2c->done);
break; break;
case STATE_IDLE: case STATE_IDLE:
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment