Commit 02aa8a8b authored by Coly Li's avatar Coly Li Committed by Jens Axboe

bcache: correct flash only vols (check all uuids)

Commit 2831231d ("bcache: reduce cache_set devices iteration by
devices_max_used") adds c->devices_max_used to reduce iteration of
c->uuids elements, this value is updated in bcache_device_attach().

But for flash only volume, when calling flash_devs_run(), the function
bcache_device_attach() is not called yet and c->devices_max_used is not
updated. The unexpected result is, the flash only volume won't be run
by flash_devs_run().

This patch fixes the issue by iterate all c->uuids elements in
flash_devs_run(). c->devices_max_used will be updated properly when
bcache_device_attach() gets called.

[mlyle: commit subject edited for character limit]

Fixes: 2831231d ("bcache: reduce cache_set devices iteration by devices_max_used")
Reported-by: default avatarTang Junhui <tang.junhui@zte.com.cn>
Signed-off-by: default avatarColy Li <colyli@suse.de>
Reviewed-by: default avatarMichael Lyle <mlyle@lyle.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9c722588
...@@ -1274,7 +1274,7 @@ static int flash_devs_run(struct cache_set *c) ...@@ -1274,7 +1274,7 @@ static int flash_devs_run(struct cache_set *c)
struct uuid_entry *u; struct uuid_entry *u;
for (u = c->uuids; for (u = c->uuids;
u < c->uuids + c->devices_max_used && !ret; u < c->uuids + c->nr_uuids && !ret;
u++) u++)
if (UUID_FLASH_ONLY(u)) if (UUID_FLASH_ONLY(u))
ret = flash_dev_run(c, u); ret = flash_dev_run(c, u);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment