Commit 02ecc41a authored by Borislav Petkov's avatar Borislav Petkov Committed by Thomas Gleixner

x86, microcode: Limit the microcode reloading to 64-bit for now

First, there was this: https://bugzilla.kernel.org/show_bug.cgi?id=88001

The problem there was that microcode patches are not being reapplied
after suspend-to-ram. It was important to reapply them, though, because
of for example Haswell's TSX erratum which disabled TSX instructions
with a microcode patch.

A simple fix was fb86b973 ("x86, microcode: Update BSPs microcode
on resume") but, as it is often the case, simple fixes are too
simple. This one causes 32-bit resume to fail:

https://bugzilla.kernel.org/show_bug.cgi?id=88391

Properly fixing this would require more involved changes for which it
is too late now, right before the merge window. Thus, limit this to
64-bit only temporarily.
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Link: http://lkml.kernel.org/r/1417353999-32236-1-git-send-email-bp@alien8.deSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent e2e68ae6
...@@ -465,6 +465,7 @@ static void mc_bp_resume(void) ...@@ -465,6 +465,7 @@ static void mc_bp_resume(void)
if (uci->valid && uci->mc) if (uci->valid && uci->mc)
microcode_ops->apply_microcode(cpu); microcode_ops->apply_microcode(cpu);
#ifdef CONFIG_X86_64
else if (!uci->mc) else if (!uci->mc)
/* /*
* We might resume and not have applied late microcode but still * We might resume and not have applied late microcode but still
...@@ -473,6 +474,7 @@ static void mc_bp_resume(void) ...@@ -473,6 +474,7 @@ static void mc_bp_resume(void)
* applying patches early on the APs. * applying patches early on the APs.
*/ */
load_ucode_ap(); load_ucode_ap();
#endif
} }
static struct syscore_ops mc_syscore_ops = { static struct syscore_ops mc_syscore_ops = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment