Commit 03890359 authored by Dan Carpenter's avatar Dan Carpenter Committed by Corey Minyard

ipmi_si: Potential array underflow in hotmod_handler()

The "ival" variable needs to signed so that we don't read before the
start of the str[] array.  This would only happen the user passed in a
module parameter that was just comprised of space characters.

Fixes: e80444ae4fc3 ("ipmi_si: Switch hotmod to use a platform device")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Message-Id: <20190222195530.GA306@kadam>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent 90b2d4f1
......@@ -187,7 +187,8 @@ static int hotmod_handler(const char *val, const struct kernel_param *kp)
char *str = kstrdup(val, GFP_KERNEL), *curr, *next;
int rv;
struct ipmi_plat_data h;
unsigned int len, ival;
unsigned int len;
int ival;
if (!str)
return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment