Commit 045afac4 authored by Anirudh Venkataramanan's avatar Anirudh Venkataramanan Committed by Jakub Kicinski

ice: Change ice_info_get_dsn to be void

ice_info_get_dsn always returns 0, so just make it void.
Signed-off-by: default avatarAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ac382a09
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
#include "ice_devlink.h" #include "ice_devlink.h"
#include "ice_fw_update.h" #include "ice_fw_update.h"
static int ice_info_get_dsn(struct ice_pf *pf, char *buf, size_t len) static void ice_info_get_dsn(struct ice_pf *pf, char *buf, size_t len)
{ {
u8 dsn[8]; u8 dsn[8];
...@@ -14,8 +14,6 @@ static int ice_info_get_dsn(struct ice_pf *pf, char *buf, size_t len) ...@@ -14,8 +14,6 @@ static int ice_info_get_dsn(struct ice_pf *pf, char *buf, size_t len)
put_unaligned_be64(pci_get_dsn(pf->pdev), dsn); put_unaligned_be64(pci_get_dsn(pf->pdev), dsn);
snprintf(buf, len, "%8phD", dsn); snprintf(buf, len, "%8phD", dsn);
return 0;
} }
static int ice_info_pba(struct ice_pf *pf, char *buf, size_t len) static int ice_info_pba(struct ice_pf *pf, char *buf, size_t len)
...@@ -178,11 +176,7 @@ static int ice_devlink_info_get(struct devlink *devlink, ...@@ -178,11 +176,7 @@ static int ice_devlink_info_get(struct devlink *devlink,
return err; return err;
} }
err = ice_info_get_dsn(pf, buf, sizeof(buf)); ice_info_get_dsn(pf, buf, sizeof(buf));
if (err) {
NL_SET_ERR_MSG_MOD(extack, "Unable to obtain serial number");
return err;
}
err = devlink_info_serial_number_put(req, buf); err = devlink_info_serial_number_put(req, buf);
if (err) { if (err) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment