Commit 04c66dee authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab

media: pxa_camera: Drop usage of .set_mbus_config()

The subdev .set_mbus_config() operation is deprecated and will be
dropped. Drop its usage from the pxa_camera driver, querying the sensor
bus configuration instead of setting it. Only the ov6650 driver supports
the operation, any platform that experiences issues with this change
should update the ov6650 configuration to match what pxa_camera
supports.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 336136e1
...@@ -1573,17 +1573,16 @@ static int pxa_camera_set_bus_param(struct pxa_camera_dev *pcdev) ...@@ -1573,17 +1573,16 @@ static int pxa_camera_set_bus_param(struct pxa_camera_dev *pcdev)
mbus_config |= V4L2_MBUS_PCLK_SAMPLE_FALLING; mbus_config |= V4L2_MBUS_PCLK_SAMPLE_FALLING;
mbus_config |= V4L2_MBUS_DATA_ACTIVE_HIGH; mbus_config |= V4L2_MBUS_DATA_ACTIVE_HIGH;
cfg.flags = mbus_config; ret = sensor_call(pcdev, pad, get_mbus_config, 0, &cfg);
ret = sensor_call(pcdev, pad, set_mbus_config, 0, &cfg);
if (ret < 0 && ret != -ENOIOCTLCMD) { if (ret < 0 && ret != -ENOIOCTLCMD) {
dev_err(pcdev_to_dev(pcdev), dev_err(pcdev_to_dev(pcdev),
"Failed to call set_mbus_config: %d\n", ret); "Failed to call get_mbus_config: %d\n", ret);
return ret; return ret;
} }
/* /*
* If the requested media bus configuration has not been fully applied * If the media bus configuration of the sensor differs, make sure it
* make sure it is supported by the platform. * is supported by the platform.
* *
* PXA does not support V4L2_MBUS_DATA_ACTIVE_LOW and the bus mastering * PXA does not support V4L2_MBUS_DATA_ACTIVE_LOW and the bus mastering
* roles should match. * roles should match.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment