Commit 04d19184 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Stephen Boyd

clk: bcm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230312161512.2715500-6-u.kleine-koenig@pengutronix.deReviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent b3438f55
...@@ -92,15 +92,13 @@ static int clk_dvp_probe(struct platform_device *pdev) ...@@ -92,15 +92,13 @@ static int clk_dvp_probe(struct platform_device *pdev)
return ret; return ret;
}; };
static int clk_dvp_remove(struct platform_device *pdev) static void clk_dvp_remove(struct platform_device *pdev)
{ {
struct clk_dvp *dvp = platform_get_drvdata(pdev); struct clk_dvp *dvp = platform_get_drvdata(pdev);
struct clk_hw_onecell_data *data = dvp->data; struct clk_hw_onecell_data *data = dvp->data;
clk_hw_unregister_gate(data->hws[1]); clk_hw_unregister_gate(data->hws[1]);
clk_hw_unregister_gate(data->hws[0]); clk_hw_unregister_gate(data->hws[0]);
return 0;
} }
static const struct of_device_id clk_dvp_dt_ids[] = { static const struct of_device_id clk_dvp_dt_ids[] = {
...@@ -111,7 +109,7 @@ MODULE_DEVICE_TABLE(of, clk_dvp_dt_ids); ...@@ -111,7 +109,7 @@ MODULE_DEVICE_TABLE(of, clk_dvp_dt_ids);
static struct platform_driver clk_dvp_driver = { static struct platform_driver clk_dvp_driver = {
.probe = clk_dvp_probe, .probe = clk_dvp_probe,
.remove = clk_dvp_remove, .remove_new = clk_dvp_remove,
.driver = { .driver = {
.name = "brcm2711-dvp", .name = "brcm2711-dvp",
.of_match_table = clk_dvp_dt_ids, .of_match_table = clk_dvp_dt_ids,
......
...@@ -541,7 +541,7 @@ static int clk_bcm63xx_probe(struct platform_device *pdev) ...@@ -541,7 +541,7 @@ static int clk_bcm63xx_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int clk_bcm63xx_remove(struct platform_device *pdev) static void clk_bcm63xx_remove(struct platform_device *pdev)
{ {
struct clk_bcm63xx_hw *hw = platform_get_drvdata(pdev); struct clk_bcm63xx_hw *hw = platform_get_drvdata(pdev);
int i; int i;
...@@ -552,8 +552,6 @@ static int clk_bcm63xx_remove(struct platform_device *pdev) ...@@ -552,8 +552,6 @@ static int clk_bcm63xx_remove(struct platform_device *pdev)
if (!IS_ERR(hw->data.hws[i])) if (!IS_ERR(hw->data.hws[i]))
clk_hw_unregister_gate(hw->data.hws[i]); clk_hw_unregister_gate(hw->data.hws[i]);
} }
return 0;
} }
static const struct of_device_id clk_bcm63xx_dt_ids[] = { static const struct of_device_id clk_bcm63xx_dt_ids[] = {
...@@ -570,7 +568,7 @@ static const struct of_device_id clk_bcm63xx_dt_ids[] = { ...@@ -570,7 +568,7 @@ static const struct of_device_id clk_bcm63xx_dt_ids[] = {
static struct platform_driver clk_bcm63xx = { static struct platform_driver clk_bcm63xx = {
.probe = clk_bcm63xx_probe, .probe = clk_bcm63xx_probe,
.remove = clk_bcm63xx_remove, .remove_new = clk_bcm63xx_remove,
.driver = { .driver = {
.name = "bcm63xx-clock", .name = "bcm63xx-clock",
.of_match_table = clk_bcm63xx_dt_ids, .of_match_table = clk_bcm63xx_dt_ids,
......
...@@ -439,13 +439,11 @@ static int raspberrypi_clk_probe(struct platform_device *pdev) ...@@ -439,13 +439,11 @@ static int raspberrypi_clk_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int raspberrypi_clk_remove(struct platform_device *pdev) static void raspberrypi_clk_remove(struct platform_device *pdev)
{ {
struct raspberrypi_clk *rpi = platform_get_drvdata(pdev); struct raspberrypi_clk *rpi = platform_get_drvdata(pdev);
platform_device_unregister(rpi->cpufreq); platform_device_unregister(rpi->cpufreq);
return 0;
} }
static const struct of_device_id raspberrypi_clk_match[] = { static const struct of_device_id raspberrypi_clk_match[] = {
...@@ -460,7 +458,7 @@ static struct platform_driver raspberrypi_clk_driver = { ...@@ -460,7 +458,7 @@ static struct platform_driver raspberrypi_clk_driver = {
.of_match_table = raspberrypi_clk_match, .of_match_table = raspberrypi_clk_match,
}, },
.probe = raspberrypi_clk_probe, .probe = raspberrypi_clk_probe,
.remove = raspberrypi_clk_remove, .remove_new = raspberrypi_clk_remove,
}; };
module_platform_driver(raspberrypi_clk_driver); module_platform_driver(raspberrypi_clk_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment