Commit 04f4f33c authored by Rob Herring (Arm)'s avatar Rob Herring (Arm) Committed by Joerg Roedel

iommu: Use of_property_present()

Use of_property_present() to test for property presence rather than
of_(find|get)_property(). This is part of a larger effort to remove
callers of of_find_property() and similar functions. of_find_property()
leaks the DT struct property and data pointers which is a problem for
dynamically allocated nodes which may be freed.
Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
Reviewed-by: default avatarRobin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/20240731191312.1710417-6-robh@kernel.orgSigned-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 84b2baf4
...@@ -416,14 +416,12 @@ static struct iommu_group *fsl_pamu_device_group(struct device *dev) ...@@ -416,14 +416,12 @@ static struct iommu_group *fsl_pamu_device_group(struct device *dev)
static struct iommu_device *fsl_pamu_probe_device(struct device *dev) static struct iommu_device *fsl_pamu_probe_device(struct device *dev)
{ {
int len;
/* /*
* uboot must fill the fsl,liodn for platform devices to be supported by * uboot must fill the fsl,liodn for platform devices to be supported by
* the iommu. * the iommu.
*/ */
if (!dev_is_pci(dev) && if (!dev_is_pci(dev) &&
!of_get_property(dev->of_node, "fsl,liodn", &len)) !of_property_present(dev->of_node, "fsl,liodn"))
return ERR_PTR(-ENODEV); return ERR_PTR(-ENODEV);
return &pamu_iommu; return &pamu_iommu;
......
...@@ -214,7 +214,7 @@ void of_iommu_get_resv_regions(struct device *dev, struct list_head *list) ...@@ -214,7 +214,7 @@ void of_iommu_get_resv_regions(struct device *dev, struct list_head *list)
* that represent reservations in the IOVA space, which are regions that should * that represent reservations in the IOVA space, which are regions that should
* not be mapped. * not be mapped.
*/ */
if (of_find_property(it.node, "reg", NULL)) { if (of_property_present(it.node, "reg")) {
err = of_address_to_resource(it.node, 0, &phys); err = of_address_to_resource(it.node, 0, &phys);
if (err < 0) { if (err < 0) {
dev_err(dev, "failed to parse memory region %pOF: %d\n", dev_err(dev, "failed to parse memory region %pOF: %d\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment