Commit 05340d4a authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Alex Elder

xfs: log timestamp changes to the source inode in rename

Now that we don't mark VFS inodes dirty anymore for internal
timestamp changes, but rely on the transaction subsystem to push
them out, we need to explicitly log the source inode in rename after
updating it's timestamps to make sure the changes actually get
forced out by sync/fsync or an AIL push.

We already account for the fourth inode in the log reservation, as a
rename of directories needs to update the nlink field, so just
adding the xfs_trans_log_inode call is enough.

This fixes the xfsqa 065 regression introduced by:

	"xfs: don't use vfs writeback for pure metadata modifications"
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
parent c76febef
...@@ -297,6 +297,7 @@ xfs_rename( ...@@ -297,6 +297,7 @@ xfs_rename(
* it and some incremental backup programs won't work without it. * it and some incremental backup programs won't work without it.
*/ */
xfs_trans_ichgtime(tp, src_ip, XFS_ICHGTIME_CHG); xfs_trans_ichgtime(tp, src_ip, XFS_ICHGTIME_CHG);
xfs_trans_log_inode(tp, src_ip, XFS_ILOG_CORE);
/* /*
* Adjust the link count on src_dp. This is necessary when * Adjust the link count on src_dp. This is necessary when
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment