Commit 0729d995 authored by Trond Myklebust's avatar Trond Myklebust Committed by Anna Schumaker

SUNRPC: Ensure to ratelimit the "server not responding" syslog messages

In particular, the timeout messages can be very noisy, so we ought to
ratelimit them in order to avoid spamming the syslog.
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent da953063
...@@ -2328,7 +2328,8 @@ rpc_check_timeout(struct rpc_task *task) ...@@ -2328,7 +2328,8 @@ rpc_check_timeout(struct rpc_task *task)
return; return;
if (clnt->cl_chatty) { if (clnt->cl_chatty) {
printk(KERN_NOTICE "%s: server %s not responding, timed out\n", pr_notice_ratelimited(
"%s: server %s not responding, timed out\n",
clnt->cl_program->name, clnt->cl_program->name,
task->tk_xprt->servername); task->tk_xprt->servername);
} }
...@@ -2342,9 +2343,10 @@ rpc_check_timeout(struct rpc_task *task) ...@@ -2342,9 +2343,10 @@ rpc_check_timeout(struct rpc_task *task)
if (!(task->tk_flags & RPC_CALL_MAJORSEEN)) { if (!(task->tk_flags & RPC_CALL_MAJORSEEN)) {
task->tk_flags |= RPC_CALL_MAJORSEEN; task->tk_flags |= RPC_CALL_MAJORSEEN;
if (clnt->cl_chatty) { if (clnt->cl_chatty) {
printk(KERN_NOTICE "%s: server %s not responding, still trying\n", pr_notice_ratelimited(
clnt->cl_program->name, "%s: server %s not responding, still trying\n",
task->tk_xprt->servername); clnt->cl_program->name,
task->tk_xprt->servername);
} }
} }
rpc_force_rebind(clnt); rpc_force_rebind(clnt);
...@@ -2374,7 +2376,7 @@ call_decode(struct rpc_task *task) ...@@ -2374,7 +2376,7 @@ call_decode(struct rpc_task *task)
if (task->tk_flags & RPC_CALL_MAJORSEEN) { if (task->tk_flags & RPC_CALL_MAJORSEEN) {
if (clnt->cl_chatty) { if (clnt->cl_chatty) {
printk(KERN_NOTICE "%s: server %s OK\n", pr_notice_ratelimited("%s: server %s OK\n",
clnt->cl_program->name, clnt->cl_program->name,
task->tk_xprt->servername); task->tk_xprt->servername);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment