Commit 074fca3a authored by Majd Dibbiny's avatar Majd Dibbiny Committed by Jason Gunthorpe

RDMA/mlx5: Fix fence type for IB_WR_LOCAL_INV WR

Currently, for IB_WR_LOCAL_INV WR, when the next fence is None, the
current fence will be SMALL instead of Normal Fence.

Without this patch krping doesn't work on CX-5 devices and throws
following error:

The error messages are from CX5 driver are: (from server side)
[ 710.434014] mlx5_0:dump_cqe:278:(pid 2712): dump error cqe
[ 710.434016] 00000000 00000000 00000000 00000000
[ 710.434016] 00000000 00000000 00000000 00000000
[ 710.434017] 00000000 00000000 00000000 00000000
[ 710.434018] 00000000 93003204 100000b8 000524d2
[ 710.434019] krping: cq completion failed with wr_id 0 status 4 opcode 128 vender_err 32

Fixed the logic to set the correct fence type.

Fixes: 6e8484c5 ("RDMA/mlx5: set UMR wqe fence according to HCA cap")
Signed-off-by: default avatarMajd Dibbiny <majd@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 99b77fef
...@@ -4678,17 +4678,18 @@ static int _mlx5_ib_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr, ...@@ -4678,17 +4678,18 @@ static int _mlx5_ib_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr,
goto out; goto out;
} }
if (wr->opcode == IB_WR_LOCAL_INV || if (wr->opcode == IB_WR_REG_MR) {
wr->opcode == IB_WR_REG_MR) {
fence = dev->umr_fence; fence = dev->umr_fence;
next_fence = MLX5_FENCE_MODE_INITIATOR_SMALL; next_fence = MLX5_FENCE_MODE_INITIATOR_SMALL;
} else if (wr->send_flags & IB_SEND_FENCE) { } else {
if (qp->next_fence) if (wr->send_flags & IB_SEND_FENCE) {
fence = MLX5_FENCE_MODE_SMALL_AND_FENCE; if (qp->next_fence)
else fence = MLX5_FENCE_MODE_SMALL_AND_FENCE;
fence = MLX5_FENCE_MODE_FENCE; else
} else { fence = MLX5_FENCE_MODE_FENCE;
fence = qp->next_fence; } else {
fence = qp->next_fence;
}
} }
switch (ibqp->qp_type) { switch (ibqp->qp_type) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment