Commit 07d03559 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Andy Shevchenko

auxdisplay: cfag12864bfb: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarMiguel Ojeda <ojeda@kernel.org>
Reviewed-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent d8abf9d4
...@@ -96,7 +96,7 @@ static int cfag12864bfb_probe(struct platform_device *device) ...@@ -96,7 +96,7 @@ static int cfag12864bfb_probe(struct platform_device *device)
return ret; return ret;
} }
static int cfag12864bfb_remove(struct platform_device *device) static void cfag12864bfb_remove(struct platform_device *device)
{ {
struct fb_info *info = platform_get_drvdata(device); struct fb_info *info = platform_get_drvdata(device);
...@@ -104,13 +104,11 @@ static int cfag12864bfb_remove(struct platform_device *device) ...@@ -104,13 +104,11 @@ static int cfag12864bfb_remove(struct platform_device *device)
unregister_framebuffer(info); unregister_framebuffer(info);
framebuffer_release(info); framebuffer_release(info);
} }
return 0;
} }
static struct platform_driver cfag12864bfb_driver = { static struct platform_driver cfag12864bfb_driver = {
.probe = cfag12864bfb_probe, .probe = cfag12864bfb_probe,
.remove = cfag12864bfb_remove, .remove_new = cfag12864bfb_remove,
.driver = { .driver = {
.name = CFAG12864BFB_NAME, .name = CFAG12864BFB_NAME,
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment