Commit 07dcf8e9 authored by Fabio Estevam's avatar Fabio Estevam Committed by David S. Miller

net: fec: Do a sanity check on the gpio number

Check whether the phy-reset GPIO is valid, prior to requesting it.

In the case a board does not provide a phy-reset GPIO, just returns immediately.

With such gpio validation in place, it is also safe to change from pr_debug to
dev_err in the case the gpio request fails.
Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent eb6b9a8c
...@@ -1689,10 +1689,13 @@ static void fec_reset_phy(struct platform_device *pdev) ...@@ -1689,10 +1689,13 @@ static void fec_reset_phy(struct platform_device *pdev)
msec = 1; msec = 1;
phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0); phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0);
if (!gpio_is_valid(phy_reset))
return;
err = devm_gpio_request_one(&pdev->dev, phy_reset, err = devm_gpio_request_one(&pdev->dev, phy_reset,
GPIOF_OUT_INIT_LOW, "phy-reset"); GPIOF_OUT_INIT_LOW, "phy-reset");
if (err) { if (err) {
pr_debug("FEC: failed to get gpio phy-reset: %d\n", err); dev_err(&pdev->dev, "failed to get phy-reset-gpios: %d\n", err);
return; return;
} }
msleep(msec); msleep(msec);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment