Commit 07e61a97 authored by Ido Schimmel's avatar Ido Schimmel Committed by Jakub Kicinski

nexthop: Fix off-by-one error in error path

A reference was not taken for the current nexthop entry, so do not try
to put it in the error path.

Fixes: 430a0491 ("nexthop: Add support for nexthop groups")
Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ac7996d6
...@@ -1459,7 +1459,7 @@ static struct nexthop *nexthop_create_group(struct net *net, ...@@ -1459,7 +1459,7 @@ static struct nexthop *nexthop_create_group(struct net *net,
return nh; return nh;
out_no_nh: out_no_nh:
for (; i >= 0; --i) for (i--; i >= 0; --i)
nexthop_put(nhg->nh_entries[i].nh); nexthop_put(nhg->nh_entries[i].nh);
kfree(nhg->spare); kfree(nhg->spare);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment