Commit 080abad7 authored by NeilBrown's avatar NeilBrown Committed by Anna Schumaker

NFS: restore module put when manager exits.

Commit f49169c9 ("NFSD: Remove svc_serv_ops::svo_module") removed
calls to module_put_and_kthread_exit() from threads that acted as SUNRPC
servers and had a related svc_serv_ops structure.  This was correct.

It ALSO removed the module_put_and_kthread_exit() call from
nfs4_run_state_manager() which is NOT a SUNRPC service.

Consequently every time the NFSv4 state manager runs the module count
increments and won't be decremented.  So the nfsv4 module cannot be
unloaded.

So restore the module_put_and_kthread_exit() call.

Fixes: f49169c9 ("NFSD: Remove svc_serv_ops::svo_module")
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 03c765b0
...@@ -2753,5 +2753,6 @@ static int nfs4_run_state_manager(void *ptr) ...@@ -2753,5 +2753,6 @@ static int nfs4_run_state_manager(void *ptr)
goto again; goto again;
nfs_put_client(clp); nfs_put_client(clp);
module_put_and_kthread_exit(0);
return 0; return 0;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment