Commit 0844d36f authored by Tom Rix's avatar Tom Rix Committed by David S. Miller

USB2NET : SR9800 : change SR9800_BULKIN_SIZE from global to static

Smatch reports this issue
sr9800.h:166:53: warning: symbol 'SR9800_BULKIN_SIZE' was not declared. Should it be static?

Global variables should not be defined in header files.
This only works because sr9800.h in only included by sr9800.c
Change the storage-class specifier to static.
And since it does not change add type qualifier const.
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6f37c9f9
...@@ -163,7 +163,7 @@ ...@@ -163,7 +163,7 @@
#define SR9800_MAX_BULKIN_24K 6 #define SR9800_MAX_BULKIN_24K 6
#define SR9800_MAX_BULKIN_32K 7 #define SR9800_MAX_BULKIN_32K 7
struct {unsigned short size, byte_cnt, threshold; } SR9800_BULKIN_SIZE[] = { static const struct {unsigned short size, byte_cnt, threshold; } SR9800_BULKIN_SIZE[] = {
/* 2k */ /* 2k */
{2048, 0x8000, 0x8001}, {2048, 0x8000, 0x8001},
/* 4k */ /* 4k */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment