Commit 08a7e33c authored by Ard Biesheuvel's avatar Ard Biesheuvel Committed by Herbert Xu

crypto: tcrypt - don't initialize at subsys_initcall time

Commit c4741b23 ("crypto: run initcalls for generic implementations
earlier") converted tcrypt.ko's module_init() to subsys_initcall(), but
this was unintentional: tcrypt.ko currently cannot be built into the core
kernel, and so the subsys_initcall() gets converted into module_init()
under the hood. Given that tcrypt.ko does not implement a generic version
of a crypto algorithm that has to be available early during boot, there
is no point in running the tcrypt init code earlier than implied by
module_init().

However, for crypto development purposes, we will lift the restriction
that tcrypt.ko must be built as a module, and when builtin, it makes sense
for tcrypt.ko (which does its work inside the module init function) to run
as late as possible. So let's switch to late_initcall() instead.
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
Reviewed-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent e8a3dae6
...@@ -3066,7 +3066,7 @@ static int __init tcrypt_mod_init(void) ...@@ -3066,7 +3066,7 @@ static int __init tcrypt_mod_init(void)
*/ */
static void __exit tcrypt_mod_fini(void) { } static void __exit tcrypt_mod_fini(void) { }
subsys_initcall(tcrypt_mod_init); late_initcall(tcrypt_mod_init);
module_exit(tcrypt_mod_fini); module_exit(tcrypt_mod_fini);
module_param(alg, charp, 0); module_param(alg, charp, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment