Commit 08ef8d35 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Viresh Kumar

cpufreq: s3c244x: add fallthrough comments for switch

Apparently nobody has so far caught this warning, I hit it in randconfig
build testing:

drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs':
drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
   camdiv |= S3C2440_CAMDIVN_HCLK3_HALF;
          ^
drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here
  case 3:
  ^~~~
drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
   camdiv |= S3C2440_CAMDIVN_HCLK4_HALF;
          ^
drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here
  case 4:
  ^~~~

Both look like the fallthrough is intentional, so add the new
"fallthrough;" keyword.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Acked-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 45b2bb66
...@@ -173,12 +173,14 @@ static void s3c2440_cpufreq_setdivs(struct s3c_cpufreq_config *cfg) ...@@ -173,12 +173,14 @@ static void s3c2440_cpufreq_setdivs(struct s3c_cpufreq_config *cfg)
case 6: case 6:
camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; camdiv |= S3C2440_CAMDIVN_HCLK3_HALF;
fallthrough;
case 3: case 3:
clkdiv |= S3C2440_CLKDIVN_HDIVN_3_6; clkdiv |= S3C2440_CLKDIVN_HDIVN_3_6;
break; break;
case 8: case 8:
camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; camdiv |= S3C2440_CAMDIVN_HCLK4_HALF;
fallthrough;
case 4: case 4:
clkdiv |= S3C2440_CLKDIVN_HDIVN_4_8; clkdiv |= S3C2440_CLKDIVN_HDIVN_4_8;
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment